🐛 ensure etc client generators never return nil #5749
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
/test pull-cluster-api-e2e-release-full-0-3 |
|
@fabriziopandini: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-cluster-api-test-release-0-3 |
1 similar comment
|
/test pull-cluster-api-test-release-0-3 |
|
/retest |
|
/test pull-cluster-api-test-release-0-3 |
|
/retest |
|
This seems super unrelated, I wonder if there is a fix we need to apply somehow |
|
Based on testgrid I would say it is unrelated: https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api-0.3#capi-test-release-0-3 The periodics also almost failed 5x in a row. I wonder if maybe the CI cluster performance is slightly degraded and now we're hitting all the unit test flakes which have already been fixed on main. |
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
fabriziopandini
deleted the
ensure-etcclientgenerators-never-return-nil
branch
What this PR does / why we need it:
This is a manual cherry-pick of #5710 to the release 0.3 branch.
Note. Code in this branch was slightly different than o main; unfortunately, this version is not unit-testable given that it is not possible to inject a replacement for NewClient.