Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a phase for applying the Cluster API components #573

Merged
merged 1 commit into from
Nov 3, 2018

Conversation

detiber
Copy link
Member

@detiber detiber commented Nov 2, 2018

What this PR does / why we need it:

  • add alpha phases apply-cluster-api-components subcommand
  • move cluster-api components application out of clusterdeployer

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #554

Release note:

clusterctl now has an alpha phases apply-cluster-api-components subcommand

- add `alpha phases apply-cluster-api-components` subcommand
- move cluster-api components application out of clusterdeployer
@k8s-ci-robot k8s-ci-robot requested a review from karan November 2, 2018 18:23
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 2, 2018
@k8s-ci-robot k8s-ci-robot requested a review from krousey November 2, 2018 18:23
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 2, 2018
@detiber detiber mentioned this pull request Nov 2, 2018
11 tasks
@roberthbailey
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2018
@k8s-ci-robot k8s-ci-robot merged commit 118ee9f into kubernetes-sigs:master Nov 3, 2018
@detiber detiber deleted the phases2 branch April 2, 2019 17:44
jayunit100 pushed a commit to jayunit100/cluster-api that referenced this pull request Jan 31, 2020
…readme

add service domain to the sample work-cluster manifest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants