Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix a number of exported comments #5728

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/clusterctl/client/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ type Client interface {
// DescribeCluster returns the object tree representing the status of a Cluster API cluster.
DescribeCluster(options DescribeClusterOptions) (*tree.ObjectTree, error)

// Interface for alpha features in clusterctl
// AlphaClient is an Interface for alpha features in clusterctl
AlphaClient
}

Expand Down
4 changes: 3 additions & 1 deletion cmd/clusterctl/client/config/providers_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,9 @@ import (
clusterctlv1 "sigs.k8s.io/cluster-api/cmd/clusterctl/api/v1alpha3"
)

// Core providers.
// core providers.
const (
// ClusterAPIProviderName is the name for the core provider.
ClusterAPIProviderName = "cluster-api"
)

Expand Down Expand Up @@ -66,6 +67,7 @@ const (

// Other.
const (
// ProvidersConfigKey is a constant for finding provider configurations with the ProvidersClient.
ProvidersConfigKey = "providers"
)

Expand Down
2 changes: 1 addition & 1 deletion cmd/clusterctl/client/init.go
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ func (c *clusterctlClient) Init(options InitOptions) ([]Components, error) {
return aliasComponents, nil
}

// Init returns the list of images required for init.
// InitImages returns the list of images required for init.
func (c *clusterctlClient) InitImages(options InitOptions) ([]string, error) {
// gets access to the management cluster
clusterClient, err := c.clusterClientFactory(ClusterClientFactoryInput{Kubeconfig: options.Kubeconfig})
Expand Down
4 changes: 2 additions & 2 deletions cmd/clusterctl/client/repository/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import (
type Client interface {
config.Provider

// GetVersion return the list of versions that are available in a provider repository
// GetVersions return the list of versions that are available in a provider repository
GetVersions() ([]string, error)

// Components provide access to YAML file for creating provider components.
Expand Down Expand Up @@ -151,7 +151,7 @@ type Repository interface {
// GetFile return a file for a given provider version.
GetFile(version string, path string) ([]byte, error)

// GetVersion return the list of versions that are available in a provider repository
// GetVersions return the list of versions that are available in a provider repository
GetVersions() ([]string, error)
}

Expand Down
2 changes: 1 addition & 1 deletion cmd/clusterctl/client/repository/components.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ const (
// 3. Ensure all the ClusterRoleBinding which are referencing namespaced objects have the name prefixed with the namespace name
// 4. Adds labels to all the components in order to allow easy identification of the provider objects.
type Components interface {
// configuration of the provider the provider components belongs to.
// Provider holds configuration of the provider the provider components belong to.
config.Provider

// Version of the provider.
Expand Down
2 changes: 1 addition & 1 deletion cmd/clusterctl/client/repository/components_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ func newComponentsClient(provider config.Provider, repository Repository, config
}
}

// Get returns the components from a repository.
// Raw returns the components from a repository.
func (f *componentsClient) Raw(options ComponentsOptions) ([]byte, error) {
return f.getRawBytes(&options)
}
Expand Down
2 changes: 1 addition & 1 deletion cmd/clusterctl/client/repository/repository_github.go
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ func (g *gitHubRepository) DefaultVersion() string {
return g.defaultVersion
}

// GetVersion returns the list of versions that are available in a provider repository.
// GetVersions returns the list of versions that are available in a provider repository.
func (g *gitHubRepository) GetVersions() ([]string, error) {
versions, err := g.getVersions()
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion cmd/clusterctl/client/yamlprocessor/processor.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ type Processor interface {
// list of variables that the template uses.
GetVariables([]byte) ([]string, error)

// GetVariables parses the template blob of bytes and provides a
// GetVariableMap parses the template blob of bytes and provides a
// map of variables that the template uses with their default values.
GetVariableMap([]byte) (map[string]*string, error)

Expand Down