Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add windows amd64 target to clusterctl #5650

Merged
merged 2 commits into from
Nov 15, 2021

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Nov 12, 2021

What this PR does / why we need it:

  • chore: add trimpath flag to make build more reproducible
  • feature: add windows amd64 target for clusterctl

I don't have a windows machine, but I spun one in the cloud and did a quick test and worked fine

/assign @fabriziopandini

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 12, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 12, 2021
@sbueringer
Copy link
Member

Change looks good to me. Not sure why verify failed, looks unrelated

/retest

@cpanato
Copy link
Member Author

cpanato commented Nov 12, 2021

Change looks good to me. Not sure why verify failed, looks unrelated

/retest

tried the main branch and failed as well for me

@sbueringer
Copy link
Member

sbueringer commented Nov 12, 2021

Change looks good to me. Not sure why verify failed, looks unrelated
/retest

tried the main branch and failed as well for me

I've run make generate-go-conversions-core on the current main branch and on this PR and it worked for me. Looks like it also works on other PRs. That's really weird.

@sbueringer
Copy link
Member

/test pull-cluster-api-verify-main

@sbueringer
Copy link
Member

I've also tested this PR merged into main to reproduce ~ what Prow is testing. Still worked.

Can you try to rebase on top of current main (I know it's already pretty close), just to see if that makes any difference

@cpanato cpanato force-pushed the add-windows-clusterctl branch from 982646b to db5787a Compare November 15, 2021 09:05
@cpanato
Copy link
Member Author

cpanato commented Nov 15, 2021

I've also tested this PR merged into main to reproduce ~ what Prow is testing. Still worked.

Can you try to rebase on top of current main (I know it's already pretty close), just to see if that makes any difference

same error :/

Makefile Outdated Show resolved Hide resolved
@cpanato cpanato force-pushed the add-windows-clusterctl branch from db5787a to 392ee53 Compare November 15, 2021 09:40
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 15, 2021
@@ -179,15 +179,15 @@ kind-cluster: ## Create a new kind cluster designed for testing with Tilt

.PHONY: manager-core
manager-core: ## Build core manager binary
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please make the same adjustments in test/infrastructure/docker/{Dockerfile,Makefile}?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P.S. I'll fix the golangci-lint issue via #5660

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me rebase

@cpanato cpanato force-pushed the add-windows-clusterctl branch from 392ee53 to c86f71c Compare November 15, 2021 10:24
@sbueringer
Copy link
Member

Thx!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2021
@fabriziopandini
Copy link
Member

/retest

@cpanato cpanato force-pushed the add-windows-clusterctl branch from c86f71c to 29b1cff Compare November 15, 2021 11:39
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2021
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2021
@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit 79b1f98 into kubernetes-sigs:main Nov 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.1 milestone Nov 15, 2021
@cpanato cpanato deleted the add-windows-clusterctl branch November 15, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants