-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add windows amd64 target to clusterctl #5650
✨ Add windows amd64 target to clusterctl #5650
Conversation
Change looks good to me. Not sure why verify failed, looks unrelated /retest |
tried the main branch and failed as well for me |
I've run |
/test pull-cluster-api-verify-main |
I've also tested this PR merged into main to reproduce ~ what Prow is testing. Still worked. Can you try to rebase on top of current main (I know it's already pretty close), just to see if that makes any difference |
982646b
to
db5787a
Compare
same error :/ |
db5787a
to
392ee53
Compare
@@ -179,15 +179,15 @@ kind-cluster: ## Create a new kind cluster designed for testing with Tilt | |||
|
|||
.PHONY: manager-core | |||
manager-core: ## Build core manager binary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please make the same adjustments in test/infrastructure/docker/{Dockerfile,Makefile}?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P.S. I'll fix the golangci-lint issue via #5660
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me rebase
392ee53
to
c86f71c
Compare
Thx! |
/retest |
Signed-off-by: Carlos Panato <[email protected]>
Signed-off-by: Carlos Panato <[email protected]>
c86f71c
to
29b1cff
Compare
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
I don't have a windows machine, but I spun one in the cloud and did a quick test and worked fine
/assign @fabriziopandini
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #