-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add ibmcloud provider support #5646
✨ Add ibmcloud provider support #5646
Conversation
These commits are clean to cherry-pick to 0.4.x release /cherry-pick release-0.4 |
@mkumatag: once the present PR merges, I will cherry-pick it on top of release-0.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
One note - I don't see the infrastructure-components yaml in the current latest release @https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/releases/tag/v0.1.0-alpha.2 It's there in alpha.1 though. |
This is a new release pushed sometime back, I was waiting for the prow post job to generate the artifacts, I have pushed them now. -Thanks. |
Given @fabriziopandini's comment in the original PR
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mkumatag: new pull request created: #5657 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This is a manual cherry-pick of #5640
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes kubernetes-sigs/cluster-api-provider-ibmcloud#320