Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add ibmcloud provider support #5646

Merged

Conversation

mkumatag
Copy link
Member

@mkumatag mkumatag commented Nov 12, 2021

What this PR does / why we need it:
This is a manual cherry-pick of #5640

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes kubernetes-sigs/cluster-api-provider-ibmcloud#320

@k8s-ci-robot k8s-ci-robot added this to the v1.0 milestone Nov 12, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 12, 2021
@mkumatag
Copy link
Member Author

@mkumatag
Copy link
Member Author

mkumatag commented Nov 12, 2021

These commits are clean to cherry-pick to 0.4.x release

/cherry-pick release-0.4

@k8s-infra-cherrypick-robot

@mkumatag: once the present PR merges, I will cherry-pick it on top of release-0.4 in a new PR and assign it to you.

In response to this:

These commits are clean to cherry-pick for 0.4.x release

/cherry-pick release-0.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2021
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@killianmuldoon
Copy link
Contributor

One note - I don't see the infrastructure-components yaml in the current latest release @https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/releases/tag/v0.1.0-alpha.2 It's there in alpha.1 though.

@mkumatag
Copy link
Member Author

One note - I don't see the infrastructure-components yaml in the current latest release @https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/releases/tag/v0.1.0-alpha.2 It's there in alpha.1 though.

This is a new release pushed sometime back, I was waiting for the prow post job to generate the artifacts, I have pushed them now. -Thanks.

@CecileRobertMichon
Copy link
Contributor

Given @fabriziopandini's comment in the original PR

technically this is not something we consider as eligible for back porting, but given it makes users life easier, I'm ok with an exception.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit 2887be8 into kubernetes-sigs:release-1.0 Nov 12, 2021
@k8s-infra-cherrypick-robot

@mkumatag: new pull request created: #5657

In response to this:

These commits are clean to cherry-pick to 0.4.x release

/cherry-pick release-0.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mkumatag mkumatag deleted the release-1.0-ibmcloud branch November 12, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants