-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Upgrade to controller-runtime v0.10.3 #5632
🌱 Upgrade to controller-runtime v0.10.3 #5632
Conversation
Signed-off-by: Stefan Büringer [email protected]
/lgtm |
@enxebre: once the present PR merges, I will cherry-pick it on top of release-1.0 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
just url realised this is against release-1.0 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@enxebre: base branch (release-1.0) needs to differ from target branch (release-1.0) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I thought CAPI main was using a newer version from CR main, that's why I wasn't opening this PR against CAPI main. But apparently CAPI main is using an older version from the CR release-0.10 branch. So we can do the some change on CAPI main I'll open a PR for that. |
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Let's pick up latest bugfixes from controller-runtime: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.10.3
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #