Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 e2e: self-hosted (clusterctl move) with clusterclass #5600

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

ykakarap
Copy link
Contributor

@ykakarap ykakarap commented Nov 5, 2021

What this PR does / why we need it:

This PR add another self-hosted E2E test (tests clusterctl move) to also work with ClusterClass based clusters.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 5, 2021
@ykakarap ykakarap changed the title e2e: self-hosted (clusterctl move) with clusterclass 🌱 e2e: self-hosted (clusterctl move) with clusterclass Nov 5, 2021
@ykakarap
Copy link
Contributor Author

ykakarap commented Nov 5, 2021

/test pull-cluster-api-e2e-full-main

@ykakarap
Copy link
Contributor Author

ykakarap commented Nov 6, 2021

/test pull-cluster-api-e2e-full-main

once more to check for flakes (if any) :)

@ykakarap
Copy link
Contributor Author

ykakarap commented Nov 8, 2021

/assign @fabriziopandini

@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2021
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only a small nit, otherwise lgtm

test/e2e/config/docker.yaml Outdated Show resolved Hide resolved
@randomvariable
Copy link
Member

Mostly what Fabrizio said.

@ykakarap ykakarap force-pushed the e2e-clusterctl-move branch from 6957df7 to c9d51a6 Compare November 8, 2021 18:03
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2021
@ykakarap
Copy link
Contributor Author

ykakarap commented Nov 8, 2021

/test pull-cluster-api-e2e-full-main

Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2021
@sbueringer
Copy link
Member

/lgtm

@fabriziopandini
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit 73c2ef1 into kubernetes-sigs:main Nov 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.1 milestone Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants