🌱 Add a check to the Cluster webhook to ensure ClusterClass exists #5585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
killianmuldoon
commented
Nov 4, 2021
vincepri
reviewed
Nov 4, 2021
sbueringer
reviewed
Nov 5, 2021
killianmuldoon
force-pushed
the
webhook/add-clusterclass-check
branch
from
6b6a1b6 to
8f35a42
Compare
k8s-ci-robot
added
size/XXL
|
This is now rebased on top of #5596 and shouldn't be merged before that PR. The most recent commit adds the clusterClassExists checks inline with the other validation checks. |
killianmuldoon
commented
Nov 5, 2021
sbueringer
reviewed
Nov 8, 2021
k8s-ci-robot
added
the
needs-rebase
killianmuldoon
force-pushed
the
webhook/add-clusterclass-check
branch
from
8f35a42 to
e3e343d
Compare
k8s-ci-robot
added
size/L
killianmuldoon
force-pushed
the
webhook/add-clusterclass-check
branch
from
e3e343d to
9c2b283
Compare
sbueringer
reviewed
Nov 8, 2021
killianmuldoon
force-pushed
the
webhook/add-clusterclass-check
branch
from
9c2b283 to
1e0d06a
Compare
Signed-off-by: killianmuldoon <[email protected]>
killianmuldoon
force-pushed
the
webhook/add-clusterclass-check
branch
from
1e0d06a to
ac8bed0
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: killianmuldoon [email protected]
This change adds an additional check to the Cluster Webhook to ensure that a ClusterClass referenced by a cluster exists. If the ClusterClass does not exist the Cluster creation or update is rejected.
This check introduces an expected ordering in the creation and update of the ClusterClass and Cluster objects, and it adds a client to the webhook that is used to fetch the referenced ClusterClass from the API server on Cluster creation and update.
Related to #5537