🌱 make Cluster API dev tooling to work on arm64 #5547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/lgtm |
k8s-ci-robot
added
the
lgtm
vincepri
reviewed
Nov 2, 2021
| export REGISTRY=gcr.io/k8s-staging-cluster-api | ||
| export TAG=dev | ||
| export ARCH=amd64 | ||
| export ARCH |
There was a problem hiding this comment.
Suggested change
| export ARCH | |
| export ARCH="$(go env GOARCH)" |
Nit
There was a problem hiding this comment.
shell checker was complying when I originally inlined export and $(), this is the suggested solution
There was a problem hiding this comment.
The problem is that a potential error of go env GOARCH is masked if you have it in one line
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
make Cluster API dev tooling to work on arm64