Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Updated function name HasPausedAnnotation to HasPaused and HasSkipRemediationAnnotation to HasSkipRemediation #5545

Merged
merged 1 commit into from
Dec 14, 2021
Merged

⚠️ Updated function name HasPausedAnnotation to HasPaused and HasSkipRemediationAnnotation to HasSkipRemediation #5545

merged 1 commit into from
Dec 14, 2021

Conversation

tamboliasir1
Copy link
Contributor

Thank you for opportunity and guidance.
Fixes #5539

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 31, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @tamboliasir1!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @tamboliasir1. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 31, 2021
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 31, 2021
@tamboliasir1 tamboliasir1 changed the title Updated function name HasPausedAnnotation to HasPaused 🌱 Updated function name HasPausedAnnotation to HasPaused Oct 31, 2021
enxebre
enxebre reviewed Nov 1, 2021
View reviewed changes
util/annotations/helpers.go Outdated
}

// IsExternallyManaged returns true if the object has the `managed-by` annotation.
func IsExternallyManaged(o metav1.Object) bool {
return hasAnnotation(o, clusterv1.ManagedByAnnotation)
}

//Deprecated: Please use `HasPaused` instead
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This is missing space after // and final period.

// Deprecated: this is going to be removed in a next release. Please use `HasPaused` instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it..

@tamboliasir1 tamboliasir1 requested a review from enxebre November 1, 2021 10:35
killianmuldoon
killianmuldoon reviewed Nov 1, 2021
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be a good idea to replace 'HasSkipRemediationAnnotation' in this PR too? It has the same stuttering problem.

@tamboliasir1
Copy link
Contributor Author

tamboliasir1 commented Nov 1, 2021 •
edited
Loading

@killianmuldoon Yeah sure I can do it.. Should I rename it to HasSkipRemediation with same deprecation message?

@killianmuldoon
Copy link
Contributor

@tamboliasir1 That sounds good - it's only got one usage as far as I can see, so please update there too.

CecileRobertMichon
CecileRobertMichon reviewed Nov 1, 2021
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 1, 2021
@CecileRobertMichon
Copy link
Contributor

@tamboliasir1 when you get a chance, please squash commits 1 & 2 since they are related to the same change

@fabriziopandini
Copy link
Member

lgtm pending squash

ykakarap
ykakarap reviewed Nov 2, 2021
View reviewed changes
Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending squash

util/annotations/helpers.go Outdated Show resolved Hide resolved
util/annotations/helpers.go Outdated Show resolved Hide resolved
@tamboliasir1
Copy link
Contributor Author

tamboliasir1 commented Nov 3, 2021 •
edited
Loading

Hi If I updated changes for go lint now so should I squash all commits in one or should I do squash for particular commit? Also should I mark this as '⚠️'?

@killianmuldoon
Copy link
Contributor

@tamboliasir1 you can squash this into a single commit - the :seedling marking seems right to me. This isn't breaking because the old methods are just being deprecated, not removed.

@ykakarap
Copy link
Contributor

ykakarap commented Nov 8, 2021

@tamboliasir1 Linting still seems to be failing.
FYI, you can run make lint locally to see what the problem. Generally the warning is associated with an explanation of what failed and how you can fix it.

@tamboliasir1 tamboliasir1 changed the title 🌱 Updated function name HasPausedAnnotation to HasPaused 🌱 Updated function name HasPausedAnnotation to HasPaused and HasSkipRemediationAnnotation to HasSkipRemediation Nov 20, 2021
@tamboliasir1
Copy link
Contributor Author

Updated lint and squashed git commits.

@ykakarap
Copy link
Contributor

ykakarap commented Dec 2, 2021

@tamboliasir1 The PR looks good. Thanks for working on this. :)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2021
@fabriziopandini
Copy link
Member

/retest

@enxebre
Copy link
Member

enxebre commented Dec 13, 2021

/lgtm

@enxebre enxebre mentioned this pull request Dec 14, 2021
Merged
fabriziopandini
fabriziopandini reviewed Dec 14, 2021
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2021
@fabriziopandini fabriziopandini changed the title 🌱 Updated function name HasPausedAnnotation to HasPaused and HasSkipRemediationAnnotation to HasSkipRemediation ⚠️ Updated function name HasPausedAnnotation to HasPaused and HasSkipRemediationAnnotation to HasSkipRemediation Dec 14, 2021
@fabriziopandini
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit b5d30a6 into kubernetes-sigs:main Dec 14, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.1 milestone Dec 14, 2021
@furkatgofurov7 furkatgofurov7 mentioned this pull request Jan 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@sbueringer sbueringer Awaiting requested review from sbueringer

@enxebre enxebre Awaiting requested review from enxebre

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

@ykakarap ykakarap Awaiting requested review from ykakarap

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

Assignees

@enxebre enxebre

@fabriziopandini fabriziopandini

@ykakarap ykakarap

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.

rename annotations.HasPausedAnnotation(obj) - function name stutters
7 participants
@tamboliasir1 @k8s-ci-robot @killianmuldoon @CecileRobertMichon @fabriziopandini @ykakarap @enxebre