-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Unit test and builder cleanups #5465
🌱 Unit test and builder cleanups #5465
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@killianmuldoon Could it be that there is something missing? I couldn't find 2. and 4. (and probably also not 3.)
Definitely was something missing! Should be updated now. |
Nice cleanup. Looks a lot better now! :) /lgtm |
Thanks for getting rid of some of ours todo! |
Signed-off-by: killianmuldoon <[email protected]>
a4ffbb1
to
e14d96f
Compare
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is a set of small cleanups for unit tests and the builder package:
Fixes #5207