🐛 Fix clusterctl delete when deleting providers with cluster-wide resources

[sbueringer]

What this PR does / why we need it:
WIP: we can't add new types of the cluster package to the signature as this leads to cyclic dependencies with the fake proxy implementation.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5417

[sbueringer]

@fabriziopandini PTAL when you've got some time.

If it's valid to add a new func to the interface, I think this would be the cleaner solution and I would extend the fakeProxy accordingly and add new test cases to the Test_providerComponents_Delete test.

If it's not, I only see the option to add magic to the ListResource func. This would work roughly work like that:

• if labels contains a provider label => exclude resources of CRDs which have the provider label but the value is different

P.S. Also fine for me if we want to implement the second option just to avoid the additional func in the interface.

[sbueringer]

/test pull-cluster-api-e2e-workload-upgrade-1-22-latest-main
/test pull-cluster-api-e2e-full-main

@fabriziopandini Ready for review.

Adding unit tests would have been too much effort as ListResources creates clients based on a kubeconfig. So I think I would have had to use testenv.

I added a delete in the clusterctl upgrade test to ensure it still works. Once CAPA picks up this change, CAPA also verifies that our issue is fixed (I also tested it manually with the fix as described in the linked issue)

[sbueringer]

/test pull-cluster-api-e2e-workload-upgrade-1-22-latest-main
/test pull-cluster-api-e2e-full-main

[fabriziopandini]

/lgtm
Thanks for adding a E2E test signal on this feature
@ykakarap PTAL

[sbueringer]

clusterctl delete works with CAPA: https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-aws/2848/pull-cluster-api-provider-aws-e2e/1448276798382018560/artifacts/clusters/clusterctl-upgrade-d8vl8j/clusterctl-delete.log

[ykakarap]

/lgtm
Thanks for adding a E2E test signal on this feature
@ykakarap PTAL

I will take a look tomorrow :)

[vincepri]

/approve
/hold for @ykakarap

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ykakarap]

/lgtm

[ykakarap]

@vincepri I reviewed and LGTM's the PR. You can go ahead and cancel the hold.

[vincepri]

/hold cancel