Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 book: fix make serve on MacOS #5401

Merged

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Oct 6, 2021

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:
realpath doesn't exist on MacOS (at least on a clean system). So I got the following errors before this fix:

$ mdbook serve
2021-10-06 17:33:41 [INFO] (mdbook::book): Book building has started
./util-embed.sh: line 21: realpath: command not found
./util-releaselink.sh: line 21: realpath: command not found
./util-tabulate.sh: line 21: realpath: command not found

This leads to rendering issues in e.g. the quickstart page.

This PR replaces realpath with something which should work on MacOS and on Linux (we're also already calculating the repo root the same way in our ci scripts).

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Signed-off-by: Stefan Büringer [email protected]
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 6, 2021
@vincepri
Copy link
Member

vincepri commented Oct 6, 2021

This works for me on Mac if you have coreutils installed

Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2021
@k8s-ci-robot k8s-ci-robot merged commit ad95a96 into kubernetes-sigs:main Oct 6, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Oct 6, 2021
@sbueringer sbueringer deleted the pr-fix-book-make-serve branch October 6, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants