Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 change kindest/node version for all providers in v0.3 #5389

Merged
merged 1 commit into from
Oct 5, 2021
Merged

📖 change kindest/node version for all providers in v0.3 #5389

merged 1 commit into from
Oct 5, 2021

Conversation

aartij17
Copy link
Contributor

@aartij17 aartij17 commented Oct 5, 2021 •
edited
Loading

What this PR does / why we need it:
This PR changes the kindest/node docker image version being used by all the providers. Installing CAPD v0.3 was failing because kindest/node:v1.18.16 did not exist.

Which issue(s) this PR fixes:
Fixes #5385

@k8s-ci-robot k8s-ci-robot added this to the v0.3 milestone Oct 5, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 5, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @AartiJivrajani!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 5, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @AartiJivrajani. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 5, 2021
@sbueringer
Copy link
Member

Thx for taking care of this!

/ok-to-test
/lgtm
/assign @fabriziopandini

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 5, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2021
fabriziopandini
fabriziopandini reviewed Oct 5, 2021
View reviewed changes
docs/book/src/user/quick-start.md
@@ -565,7 +565,7 @@ The Docker provider is not designed for production use and is intended for devel

```bash
clusterctl config cluster capi-quickstart --flavor development \
--kubernetes-version v1.18.16 \
--kubernetes-version v1.18.19 \
Copy link
Member

@fabriziopandini fabriziopandini Oct 5, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: should we update to v1.18.19 for all the providers?
@sbueringer opinions?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general sounds good to me. I guess we always have the problem that we don't know if they have published images. But that problem is the same for v1.18.16 and v1.18.19.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I will change the version for other providers too, thanks @fabriziopandini and @sbueringer!

@aartij17 aartij17 force-pushed the update-doc-kind-image branch from 547aba9 to eb1d144 Compare October 5, 2021 18:51
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2021
@aartij17 aartij17 changed the title 📖 change kindest/node version in case of CAPD for v0.3 📖 change kindest/node version for all providers in v0.3 Oct 5, 2021
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2021
fabriziopandini
fabriziopandini reviewed Oct 5, 2021
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2021
@sbueringer
Copy link
Member

/retest

@sbueringer
Copy link
Member

/retest

I'm glad our tests on release-0.4 and main are more stable than this :)

@fabriziopandini
Copy link
Member

/retest

1 similar comment
@fabriziopandini
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 2aee167 into kubernetes-sigs:release-0.3 Oct 5, 2021
@aartij17 aartij17 mentioned this pull request Jan 27, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@sbueringer sbueringer sbueringer left review comments

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@randomvariable randomvariable Awaiting requested review from randomvariable

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3
Development

Successfully merging this pull request may close these issues.
4 participants
@aartij17 @k8s-ci-robot @sbueringer @fabriziopandini