Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 add organizations to certificates #5387

Merged

Conversation

ykakarap
Copy link
Contributor

@ykakarap ykakarap commented Oct 5, 2021

What this PR does / why we need it:
Adds organizations to certificates to remove the following errors that are observed during tilt up.

[K8s EVENT: CertificateRequest capi-kubeadm-bootstrap-serving-cert-rr6c4 (ns: capi-kubeadm-bootstrap-system)] Certificate will be issued with an empty Issuer DN, which contravenes RFC 5280 and could break some strict clients
[K8s EVENT: CertificateRequest capi-serving-cert-n2fh6 (ns: capi-system)] Certificate will be issued with an empty Issuer DN, which contravenes RFC 5280 and could break some strict clients
[K8s EVENT: CertificateRequest capd-serving-cert-hmjpt (ns: capd-system)] Certificate will be issued with an empty Issuer DN, which contravenes RFC 5280 and could break some strict clients
[K8s EVENT: CertificateRequest capi-kubeadm-control-plane-serving-cert-4grqr (ns: capi-kubeadm-control-plane-system)] Certificate will be issued with an empty Issuer DN, which contravenes RFC 5280 and could break some strict clients

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5257

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 5, 2021
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 5, 2021
@ykakarap
Copy link
Contributor Author

ykakarap commented Oct 5, 2021

/assign @fabriziopandini

@ykakarap ykakarap changed the title add organizations to certificates 🌱 add organizations to certificates Oct 5, 2021
@sbueringer
Copy link
Member

sbueringer commented Oct 5, 2021

@ykakarap Looks good. I assume it's safe in upgrade scenarios as we re-create the Certificates anyway. Should we document this in the v1alpha4->v1beta1 migration guide?

@ykakarap
Copy link
Contributor Author

ykakarap commented Oct 5, 2021

@ykakarap Looks good. I assume it's safe in upgrade scenarios as we re-create the Certificates anyway. Should we document this in the v1alpha4->v1beta1 migration guide

@sbueringer I just did a local test and I was able to continue creating clusters after upgrading from v1alpha4->v1beta1. Are there any more elaborate checks I can perform?

@sbueringer
Copy link
Member

sbueringer commented Oct 5, 2021

@ykakarap Looks good. I assume it's safe in upgrade scenarios as we re-create the Certificates anyway. Should we document this in the v1alpha4->v1beta1 migration guide

@sbueringer I just did a local test and I was able to continue creating clusters after upgrading from v1alpha4->v1beta1. Are there any more elaborate checks I can perform?

I don't think so. I think it's safe, just wanted to mention it (in case someone has more insight and sees a problem). Let's trigger the update e2e test as well:
/test pull-cluster-api-full-e2e-main

P.S. Here is a log with the certificate re-creation during clusterctl upgrade I was referring to: https://storage.googleapis.com/kubernetes-jenkins/logs/periodic-cluster-api-e2e-main/1445386455730884608/artifacts/clusters/clusterctl-upgrade-ogusut/clusterctl-upgrade.log

@k8s-ci-robot
Copy link
Contributor

@sbueringer: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-main
  • /test pull-cluster-api-e2e-main
  • /test pull-cluster-api-test-main
  • /test pull-cluster-api-test-mink8s-main
  • /test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-main
  • /test pull-cluster-api-e2e-full-main
  • /test pull-cluster-api-e2e-ipv6-main
  • /test pull-cluster-api-e2e-workload-upgrade-1-22-latest-main
  • /test pull-cluster-api-make-main

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-main
  • pull-cluster-api-build-main
  • pull-cluster-api-e2e-ipv6-main
  • pull-cluster-api-e2e-main
  • pull-cluster-api-test-main
  • pull-cluster-api-test-mink8s-main
  • pull-cluster-api-verify-main

In response to this:

@ykakarap Looks good. I assume it's safe in upgrade scenarios as we re-create the Certificates anyway. Should we document this in the v1alpha4->v1beta1 migration guide

@sbueringer I just did a local test and I was able to continue creating clusters after upgrading from v1alpha4->v1beta1. Are there any more elaborate checks I can perform?

I don't think so. I think it's safe, just wanted to mention it (in case someone has more insight and sees a problem). Let's trigger the update e2e test as well:
/test pull-cluster-api-full-e2e-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-full-main

@fabriziopandini
Copy link
Member

lgtm pending test results

@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2021
@ykakarap ykakarap force-pushed the certificate-empty-issuer branch from 76da71a to e08fca1 Compare October 5, 2021 18:58
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2021
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2021
@vincepri
Copy link
Member

vincepri commented Oct 5, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2021
@k8s-ci-robot k8s-ci-robot merged commit e9f5000 into kubernetes-sigs:main Oct 5, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cert manager raises "Certificate will be issued with an empty Issuer DN" warning
5 participants