-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 add organizations to certificates #5387
🌱 add organizations to certificates #5387
Conversation
/assign @fabriziopandini |
@ykakarap Looks good. I assume it's safe in upgrade scenarios as we re-create the Certificates anyway. Should we document this in the v1alpha4->v1beta1 migration guide? |
@sbueringer I just did a local test and I was able to continue creating clusters after upgrading from v1alpha4->v1beta1. Are there any more elaborate checks I can perform? |
I don't think so. I think it's safe, just wanted to mention it (in case someone has more insight and sees a problem). Let's trigger the update e2e test as well: P.S. Here is a log with the certificate re-creation during clusterctl upgrade I was referring to: https://storage.googleapis.com/kubernetes-jenkins/logs/periodic-cluster-api-e2e-main/1445386455730884608/artifacts/clusters/clusterctl-upgrade-ogusut/clusterctl-upgrade.log |
@sbueringer: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-cluster-api-e2e-full-main |
lgtm pending test results |
/lgtm |
76da71a
to
e08fca1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Adds organizations to certificates to remove the following errors that are observed during
tilt up
.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #5257