🌱 Allow passing in provider contract and clusterctl binary in the clusterctl upgrade spec #5377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/testing
randomvariable
force-pushed
the
moar-capi-upgrade-variables
branch
from
0660015 to
ced3b1c
Compare
sbueringer
reviewed
Oct 4, 2021
…erctl upgrade spec Signed-off-by: Naadir Jeewa <[email protected]>
randomvariable
force-pushed
the
moar-capi-upgrade-variables
branch
from
ced3b1c to
d939d43
Compare
|
/lgtm Pending successful tests obviously. But the errors look like they are caused by a Github problem. /test pull-cluster-api-e2e-full-main |
|
/retest |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Naadir Jeewa [email protected]
What this PR does / why we need it:
I would like to run both v1alpha4 -> v1beta1 and v1alpha3 -> v1beta1 tests in the same job, so expanding the clusterctl upgrade spec to allow different provider contracts to be tested.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
/assign @sbueringer
/area testing