Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Redirect on curl k8s stable version and kustomize install #5376

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

knabben
Copy link
Member

@knabben knabben commented Oct 3, 2021

What this PR does / why we need it:
Fix Kustomize bash installation documentation and redirect stable.txt download

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 3, 2021
@knabben knabben changed the title Redirect on curl k8s stable version and kustomize install 📖 Redirect on curl k8s stable version and kustomize install Oct 3, 2021
@sbueringer
Copy link
Member

Thx!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2021
@fabriziopandini
Copy link
Member

Wondering if we should remove this and instead refer to hack/ensure-kustomize.sh that installs the exact version of kustomize we rely on under the /hack/tools/bin folder 🤔

@sbueringer
Copy link
Member

sbueringer commented Oct 4, 2021

Wondering if we should remove this and instead refer to hack/ensure-kustomize.sh that installs the exact version of kustomize we rely on under the /hack/tools/bin folder 🤔

Is an alternative, but might be good if users don't have to clone the repo.

@fabriziopandini
Copy link
Member

/lgtm

Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2021
@k8s-ci-robot k8s-ci-robot merged commit bd67468 into kubernetes-sigs:main Oct 4, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants