-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨clusterctl: generate returns better error message in case there is no management cluster available #5373
✨clusterctl: generate returns better error message in case there is no management cluster available #5373
Conversation
0462bfd
to
3b16a7b
Compare
/retitle clusterctl: generate returns better error message in case there is no management cluster available |
/retitle ✨clusterctl: generate returns better error message in case there is no management cluster available |
3b16a7b
to
56de3a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last nit from my side
56de3a6
to
a4fe42f
Compare
@ykakarap: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Wondering if we should wait after release before merging this 🤔
In this case I personally would prefer waiting until after the release. |
/hold |
Any reason to hold this? Seems a good improvement to me |
My thinking was that we don't necessarily need it in v1.0.0 and we don't have enough time to see if it introduces any kind of flakiness. (although the chance of that is very low) |
The chances of this introducing any flakiness is pretty low. Are there any other tests we can run to gain confidence that this did not introduce and unknown bugs or unexpected UX? This is a good UX improvement for uses to try 1.0, would be nice to have in the 1.0 release. |
Just to be clear. I don't have a strong opinion either way :). That was just why I wrote #5373 (comment). (We were also doing a bunch of manual testing with clusterctl locally yesterday with various upgrade scenarios with CAPD and CAPA) |
/hold cancel |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Adds better errors to clusterctl generate cluster command.
This PR also adds a few helper functions to help with detecting the state of the existing cluster.
With this PR if a user runs the following clusterctl generate command without a management cluster we get the following error:
New Error Message:
Old Error Message:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #5352