🐛 KubeadmControlPlane status.updated should be calculated appropriately #5353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes sure that the UpToDateMachines method always returns a filter based on real data. Instead of looking at (Machines - MachinesThatNeedRollout), which excludes all machines being deleted as well, looks at all machines that match the expected configuration and aren't scheduled for a rollout. Signed-off-by: Vince Prignano <[email protected]>
k8s-ci-robot
added
cncf-cla: yes
|
/lgtm Thanks for the quick fix @vincepri :) |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes sure that the UpToDateMachines method always returns
a filter based on real data. Instead of looking at
(Machines - MachinesThatNeedRollout), which excludes all machines being
deleted as well, looks at all machines that match the expected
configuration and aren't scheduled for a rollout.
Signed-off-by: Vince Prignano [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #