⚠️ Make condition.lastTransitionTime required #5303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Merged
fabriziopandini
force-pushed
the
make-condition.lastTransitionTime-required
branch
from
7c8eaa4 to
9377ba2
Compare
k8s-ci-robot
removed
the
lgtm
|
rebased... |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
fabriziopandini
deleted the
make-condition.lastTransitionTime-required
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The condition.lastTransitionTime is wrongly tagged with omitempty and this makes to optional from an OpenAPI PoV.
This PR makes this field mandatory.
Please note that this is a breaking change, however it should not create problem to the users given that our utilities for working with conditions are always setting this field.
Which issue(s) this PR fixes:
Fixes ##5233