Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Deprecate controllers/mdutil package, moving to internal #5298

Merged
merged 1 commit into from
Sep 23, 2021
Merged

🌱 Deprecate controllers/mdutil package, moving to internal #5298

merged 1 commit into from
Sep 23, 2021

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Sep 22, 2021

What this PR does / why we need it:
Creates controllers/internal/machinedeployment
Deprecate all exported funcs and consts in controllers/mdutil

Fixes #5244
Ports #5297

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Sep 22, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 22, 2021
@enxebre enxebre changed the title Move mdutil into an internal package 0.4 ⚠️ Move mdutil into an internal package 0.4 Sep 22, 2021
@enxebre enxebre changed the title ⚠️ Move mdutil into an internal package 0.4 🌱 Move mdutil into an internal package 0.4 Sep 22, 2021
@enxebre
Copy link
Member Author

enxebre commented Sep 22, 2021 •
edited
Loading

@enxebre Do we need this change in v0.4 marked as breaking?

I was thinking the same. No, I don't think so. This deprecates but maintains compatibiliy.

@vincepri
Copy link
Member

/retitle 🌱 Deprecate controllers/mdutil package, moving to internal

@k8s-ci-robot k8s-ci-robot changed the title 🌱 Move mdutil into an internal package 0.4 🌱 Deprecate controllers/mdutil package, moving to internal Sep 22, 2021
@sbueringer
Copy link
Member

I'm not entirely sure about the new package name. Maybe something like internal/util/machinedeployment or internal/mdutil would be better. But I don't have strong opinions on that so let's see what others say.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2021
@vincepri
Copy link
Member

+1 for internal/mdutil

@sbueringer sbueringer mentioned this pull request Sep 22, 2021
Merged
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2021
@enxebre
Copy link
Member Author

enxebre commented Sep 23, 2021

ok cool, updated package name.

@enxebre
Move mdutil into an internal package
a276b15 
Creates controllers/internal/machinedeployment
Deprecate all exported funcs and consts in controllers/mdutil

Fixes kubernetes-sigs#5244
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2021
@JoelSpeed
Copy link
Contributor

/lgtm

vincepri
vincepri approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6546065 into kubernetes-sigs:release-0.4 Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@sbueringer sbueringer

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.
5 participants
@enxebre @vincepri @sbueringer @JoelSpeed @k8s-ci-robot