Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Clusterctl: add support for v1alpha3 to v1beta1 upgrades #5271

Merged
merged 2 commits into from
Sep 22, 2021
Merged

✨ Clusterctl: add support for v1alpha3 to v1beta1 upgrades #5271

merged 2 commits into from
Sep 22, 2021

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
This PR add support for v1alpha3 to v1beta1 upgrades in clusterctl, under the assumption v1alpha4 and v1beta1 contract are the same.

It also add support for testing both v1alpha3 --> v1beta1 and v1alpha4 --> v1beta1 upgrades (this will require a PR in test infra as soon as this PR will be merged)

Which issue(s) this PR fixes:
Fixes #5269

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 20, 2021
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 20, 2021
sbueringer
sbueringer reviewed Sep 21, 2021
View reviewed changes
cmd/clusterctl/client/cluster/inventory_test.go Outdated Show resolved Hide resolved
cmd/clusterctl/client/cluster/inventory_test.go Outdated Show resolved Hide resolved
cmd/clusterctl/client/cluster/upgrader_test.go Show resolved Hide resolved
cmd/clusterctl/client/upgrade.go Outdated Show resolved Hide resolved
test/e2e/config/docker.yaml Show resolved Hide resolved
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 21, 2021 •
edited
Loading

@fabriziopandini: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main 89df947 link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fabriziopandini fabriziopandini mentioned this pull request Sep 21, 2021
Merged
@fabriziopandini fabriziopandini changed the title [WIP] ✨ Clusterctl: add support for v1alpha3 to v1beta1 upgrades ✨ Clusterctl: add support for v1alpha3 to v1beta1 upgrades Sep 21, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 21, 2021
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 21, 2021
vincepri
vincepri approved these changes Sep 22, 2021
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2021
@vincepri
Copy link
Member

/milestone v1.0

@k8s-ci-robot k8s-ci-robot added this to the v1.0 milestone Sep 22, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5330150 into kubernetes-sigs:master Sep 22, 2021
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.0, v0.4 Sep 22, 2021
@fabriziopandini fabriziopandini deleted the clusterctl-support-v1alpha3-v1beta1-upgrades branch September 23, 2021 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykakarap ykakarap ykakarap left review comments

@sbueringer sbueringer sbueringer left review comments

@vincepri vincepri vincepri approved these changes

@enxebre enxebre Awaiting requested review from enxebre

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.

clusterctl v1beta1 should allow upgrades starting from v1alpha3
5 participants
@fabriziopandini @k8s-ci-robot @sbueringer @vincepri @ykakarap