-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Update calico version in quickstart guide #5261
🌱 Update calico version in quickstart guide #5261
Conversation
/lgtm (I assume manually tested to make sure it works) |
I wonder if there's a URL that allows you to fetch the latest? Is that something we would want to recommend 🤔 |
Looks like there is: https://docs.projectcalico.org/manifests/calico.yaml Brings up the question if we want to explicitly test newer versions when we bump them or use latest untested :) |
Assuming that the link is always to their latest stable release, I would assume they've thoroughly tested it ahead of time? Is there anything the CAPI community would specifically test? I can't think of any reason why using their latest on top of a CAPI bootstrapped cluster would be any different than what they are testing, the only difference is maybe if it's created by a |
The only differences I could see is that we might use a newer Kubernetes version (not sure how likely that is) and we're using kind. We're only deploying Calico via kubectl apply in the quickstart doc, so no magic there (our e2e tests are using kindnet). |
Yeah - I spun up a couple of clusters and waited until the CNI was successfully deployed / node ready. I didn't test anything more advanced than that, but I assume that's all we're really looking for in the quickstart. |
For the quickstart and with Calico's release cadence I don't think there's much overhead in a manual bump like this, but if going for the latest stable is preferred I'm happy to update the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Bumps the version of Calico used in the CAPI quickstart guide.