Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Update calico version in quickstart guide #5261

Merged

Conversation

killianmuldoon
Copy link
Contributor

What this PR does / why we need it:
Bumps the version of Calico used in the CAPI quickstart guide.

@killianmuldoon killianmuldoon changed the title :seedling Update calico version in quickstart guide 🌱 Update calico version in quickstart guide Sep 17, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 17, 2021
@sbueringer
Copy link
Member

/lgtm

(I assume manually tested to make sure it works)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2021
@JoelSpeed
Copy link
Contributor

I wonder if there's a URL that allows you to fetch the latest? Is that something we would want to recommend 🤔

@sbueringer
Copy link
Member

sbueringer commented Sep 20, 2021

I wonder if there's a URL that allows you to fetch the latest? Is that something we would want to recommend 🤔

Looks like there is: https://docs.projectcalico.org/manifests/calico.yaml

Brings up the question if we want to explicitly test newer versions when we bump them or use latest untested :)
(I don't have a strong opinion either way, Calico has been very stable in that regard the last few years)

@JoelSpeed
Copy link
Contributor

Assuming that the link is always to their latest stable release, I would assume they've thoroughly tested it ahead of time? Is there anything the CAPI community would specifically test? I can't think of any reason why using their latest on top of a CAPI bootstrapped cluster would be any different than what they are testing, the only difference is maybe if it's created by a ClusterResourceSet?

@sbueringer
Copy link
Member

sbueringer commented Sep 20, 2021

The only differences I could see is that we might use a newer Kubernetes version (not sure how likely that is) and we're using kind.
But afaik that was never a problem in the past.

We're only deploying Calico via kubectl apply in the quickstart doc, so no magic there (our e2e tests are using kindnet).

@killianmuldoon
Copy link
Contributor Author

/lgtm

(I assume manually tested to make sure it works)

Yeah - I spun up a couple of clusters and waited until the CNI was successfully deployed / node ready. I didn't test anything more advanced than that, but I assume that's all we're really looking for in the quickstart.

@killianmuldoon
Copy link
Contributor Author

For the quickstart and with Calico's release cadence I don't think there's much overhead in a manual bump like this, but if going for the latest stable is preferred I'm happy to update the PR.

Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6a81b84 into kubernetes-sigs:master Sep 20, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants