🌱 Add missing constants to v1alpha3 package from release-0.3

[sbueringer]

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:

Implements #5236 (comment)

Looks like we missed a few constants we have on our release-0.3 branch. This breaks API consumers when trying to migrate from v1alpha3 to v1alpha4. (of course only when they are used in API consumer code)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[fabriziopandini]

/lgtm

[stmcginnis]

/lgtm

Matches what is in api/v1alpha4/comon_types.go. But I don't actually see these being used anywhere. Is there a reason to define them in v1alpha3?

[sbueringer]

/lgtm

Matches what is in api/v1alpha4/comon_types.go. But I don't actually see these being used anywhere. Is there a reason to define them in v1alpha3?

Idea was to keep them sync with the constants in the v1alpha3 APIs of the release-0.3 branch. Because we shouldn't drop constants in the v1alpha3 types between release-0.3 and main. (the constants should be used on the release-0.3 branch).

So it's not really for us, it's for "external" consumers of our API.

[stmcginnis]

So it's not really for us, it's for "external" consumers of our API.

Thanks, that makes a lot of sense now. :)

[vincepri]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment