Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Small cleanups to ClusterClass tests #5225

Merged
merged 1 commit into from
Sep 15, 2021
Merged

🌱 Small cleanups to ClusterClass tests #5225

merged 1 commit into from
Sep 15, 2021

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
Small cleanups on ClusterClass tests for improving maintainabilty

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 10, 2021
sbueringer
sbueringer reviewed Sep 10, 2021
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only nits, thx for cleaning this up! (will try to align in future unit tests)

controllers/topology/blueprint_test.go Outdated Show resolved Hide resolved
controllers/topology/current_state_test.go Outdated Show resolved Hide resolved
controllers/topology/current_state_test.go Outdated Show resolved Hide resolved
killianmuldoon
killianmuldoon suggested changes Sep 10, 2021
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits to clean up.

controllers/topology/blueprint_test.go Show resolved Hide resolved
controllers/topology/current_state_test.go Outdated Show resolved Hide resolved
controllers/topology/current_state_test.go Outdated Show resolved Hide resolved
controllers/topology/current_state_test.go Outdated Show resolved Hide resolved
controllers/topology/current_state_test.go Outdated Show resolved Hide resolved
controllers/topology/current_state_test.go Outdated Show resolved Hide resolved
controllers/topology/current_state_test.go Outdated Show resolved Hide resolved
controllers/topology/current_state_test.go Outdated Show resolved Hide resolved
@fabriziopandini
Copy link
Member Author

@killianmuldoon @sbueringer I should have addressed all the comments.
Let me know if I can squash

@stmcginnis
Copy link
Contributor

This looks good to me. I think all comments have been addressed, so probably good to squash.

@killianmuldoon
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2021
@sbueringer
Copy link
Member

lgtm +/- squash

@fabriziopandini fabriziopandini force-pushed the clusterclass-test-cleanups branch from b0e33e6 to 9672f4a Compare September 13, 2021 18:40
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2021
@fabriziopandini
Copy link
Member Author

squashed

@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2021
@stmcginnis
Copy link
Contributor

/lgtm

vincepri
vincepri approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6c9b898 into kubernetes-sigs:master Sep 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Sep 15, 2021
@fabriziopandini fabriziopandini deleted the clusterclass-test-cleanups branch September 23, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@killianmuldoon killianmuldoon killianmuldoon requested changes

@vincepri vincepri vincepri approved these changes

@ykakarap ykakarap Awaiting requested review from ykakarap

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@stmcginnis stmcginnis

@sbueringer sbueringer

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.
6 participants
@fabriziopandini @stmcginnis @killianmuldoon @sbueringer @k8s-ci-robot @vincepri