🌱 Allow cluster class compatible changes #5213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
sbueringer
reviewed
Sep 7, 2021
vincepri
reviewed
Sep 7, 2021
fabriziopandini
force-pushed
the
allow-clusterclass-compatible-changes
branch
from
68aa6c3 to
aaf28ed
Compare
sbueringer
reviewed
Sep 7, 2021
fabriziopandini
force-pushed
the
allow-clusterclass-compatible-changes
branch
from
aaf28ed to
ed861b4
Compare
sbueringer
reviewed
Sep 7, 2021
fabriziopandini
force-pushed
the
allow-clusterclass-compatible-changes
branch
from
ed861b4 to
3e2807a
Compare
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
vincepri
reviewed
Sep 8, 2021
fabriziopandini
force-pushed
the
allow-clusterclass-compatible-changes
branch
from
3e2807a to
718b437
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR allows compatible changes on ClusterClass, namely metadata, and template rotation.
Please note that those checks now applies to all ClusterClasses, while in a future iteration we can improve UX by not applying compatibility rules if a ClusterClass is actually not used by a Cluster.
Which issue(s) this PR fixes:
Fixes #5192
Fixes #5197