🌱 Add ClusterTopologyMachineDeploymentLabelName to MachineDeployment templates

[anusha94]

Adding ClusterTopologyMachineDeploymentLabelName to the generated
Bootstrap and Infrastructure Machine templates

What this PR does / why we need it:
ClusterTopologyMachineDeploymentLabelName has to be added on the generated MachineDeployment objects to track the name of the MD topology it represents. Bootstrap and InfrastructureMachine templates are also generated as part of computeMachineDeployment. Hence, adding the label on these templates as well.

Fixes #5193

[k8s-ci-robot]

Hi @anusha94. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[anusha94]

I thought of adding an assertion after assert on MD object label

But the Spec.InfrastructureRef and Spec.Bootstrap.ConfigRef are of type *corev1.ObjectReference. I wasn't quite sure of how to get the Labels on these templates for assertion.

lmk how can I test this? Thanks!

[geetikabatra]

LGTM

[fabriziopandini]

/ok-to-test

[fabriziopandini]

/test pull-cluster-api-test-main-mink8s

[fabriziopandini]

lmk how can I test this?

A possible solution is to extend the test case implemented at

cluster-api/controllers/topology/desired_state_test.go

Line 492 in d75a696

t.Run("Generates the machine deployment and the referenced templates", func(t *testing.T) {

by adding assertions on actual.InfrastructureMachineTemplate.GetLabels() and actual.BootstrapTemplate.GetLabels(), similar to what we are already doing at

cluster-api/controllers/topology/desired_state_test.go

Line 506 in d75a696

g.Expect(actualMd.Labels).To(HaveKeyWithValue(clusterv1.ClusterTopologyMachineDeploymentLabelName, "big-pool-of-machines"))

[sbueringer]

/lgtm (I think you can squash)

[anusha94]

/test pull-cluster-api-test-main-mink8s

[sbueringer]

/lgtm

[vincepri]

/approve

[fabriziopandini]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [fabriziopandini,vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sbueringer]

/retest