Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add GitHub Action to automate creating a release #5188

Merged

Conversation

CecileRobertMichon
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon commented Sep 1, 2021

What this PR does / why we need it: This is part 1 of automating our release process. It adds a GH action for creating the draft release with release notes and generated artifacts on GitHub when a tag is pushed.

Tested on my fork: https://github.com/CecileRobertMichon/cluster-api/actions/runs/1192045111
Resulting draft release: https://github.com/CecileRobertMichon/cluster-api/releases/tag/untagged-88e1db0cbb70a7f9fe19

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 1, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 1, 2021
@CecileRobertMichon CecileRobertMichon changed the title 🌱 Add GitHub Action to automate creating a release [WIP] 🌱 Add GitHub Action to automate creating a release Sep 1, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 1, 2021
@CecileRobertMichon CecileRobertMichon changed the title [WIP] 🌱 Add GitHub Action to automate creating a release 🌱 Add GitHub Action to automate creating a release Sep 1, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 1, 2021
@CecileRobertMichon
Copy link
Contributor Author

CecileRobertMichon commented Sep 1, 2021

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2021
@CecileRobertMichon
Copy link
Contributor Author

/hold cancel

verified this works

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2021
@CecileRobertMichon
Copy link
Contributor Author

/assign @vincepri

Makefile Outdated Show resolved Hide resolved
@vincepri
Copy link
Member

vincepri commented Sep 2, 2021

@CecileRobertMichon This is amazing ❤️ thank you so much for doing this!

Do you have a screenshot of the resulting draft on your fork? The link doesn't seem to work for me

@sbueringer
Copy link
Member

sbueringer commented Sep 2, 2021

Do you have a screenshot of the resulting draft on your fork? The link doesn't seem to work for me

I assume that's because draft release are not published and thus private :)

Very nice!

@CecileRobertMichon
Copy link
Contributor Author

CecileRobertMichon commented Sep 2, 2021

The release notes are pretty long but here are screenshots of the beginning and the end:

Screen Shot 2021-09-02 at 10 12 09 AM

Screen Shot 2021-09-02 at 10 12 27 AM

(it's using an old tag I had on my fork as the previous tag)

@vincepri
Copy link
Member

vincepri commented Sep 2, 2021

This is great!

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 2, 2021
@CecileRobertMichon CecileRobertMichon force-pushed the release-action branch 2 times, most recently from 7d31f5b to b198100 Compare September 2, 2021 15:35
Makefile Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 2, 2021
@CecileRobertMichon CecileRobertMichon force-pushed the release-action branch 2 times, most recently from 1519c34 to b84fe29 Compare September 2, 2021 18:32
@CecileRobertMichon
Copy link
Contributor Author

/hold cancel

latest run: https://github.com/CecileRobertMichon/cluster-api/runs/3499020825
resulting release:

Screen Shot 2021-09-02 at 2 46 30 PM

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 2, 2021
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@CecileRobertMichon CecileRobertMichon force-pushed the release-action branch 2 times, most recently from 727ebef to 46e1377 Compare September 2, 2021 20:27
@CecileRobertMichon
Copy link
Contributor Author

Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2021
@k8s-ci-robot k8s-ci-robot merged commit b99ff45 into kubernetes-sigs:master Sep 2, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Sep 2, 2021
@CecileRobertMichon
Copy link
Contributor Author

/cherry-pick release-0.3

@k8s-infra-cherrypick-robot

@CecileRobertMichon: #5188 failed to apply on top of branch "release-0.3":

Applying: seedling: Add GitHub Action to automate creating a release
Using index info to reconstruct a base tree...
M	.gitignore
M	Makefile
M	docs/developer/releasing.md
M	test/infrastructure/docker/Makefile
Falling back to patching base and 3-way merge...
Auto-merging test/infrastructure/docker/Makefile
CONFLICT (content): Merge conflict in test/infrastructure/docker/Makefile
Auto-merging docs/developer/releasing.md
CONFLICT (content): Merge conflict in docs/developer/releasing.md
Auto-merging Makefile
CONFLICT (content): Merge conflict in Makefile
Auto-merging .gitignore
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 seedling: Add GitHub Action to automate creating a release
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants