🐛 Add AGE column to our CRDs

[Jont828]

What this PR does / why we need it: This adds the AGE column to all our CRDs to make the printed output consistent with the built in K8s resources.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5159

[k8s-ci-robot]

Hi @Jont828. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vincepri]

/ok-to-test

[sbueringer]

@Jont828 Looks good.

Can you please also add the column to: (those are the remaining two CRDs which also already have additionalPrinterColumns)

• providers.clusterctl.cluster.x-k8s.io
• kubeadmcontrolplanes.controlplane.cluster.x-k8s.io

I wonder if it makes sense to add the column to all our CRDs, even when they currently don't have additionalPrinterColumns. The reason would be that we might forget to add the age column when we add other columns to those CRDs otherwise. This would affect:

• clusterresourcesetbindings.addons.cluster.x-k8s.io
• clusterresourcesets.addons.cluster.x-k8s.io
• clusterclasses.cluster.x-k8s.io
• kubeadmcontrolplanetemplates.controlplane.cluster.x-k8s.io
• kubeadmconfigs.bootstrap.cluster.x-k8s.io
• kubeadmconfigtemplates.bootstrap.cluster.x-k8s.io
• CRDs in test/infrastructure/docker/config/crd/bases

[fabriziopandini]

lgtm apart addressing comment about description (if there is agreement for it)
+1 to add AGE to all CRDs

Note: apart for ClusterClass that should be included in this PR, It will be ok to address other API types in follow up PRs given that we track the missing bits in a issue

[CecileRobertMichon]

+1 to add AGE to all CRDs
+2

Let's also add AGE to Docker provider CRDs (either in this PR or in a later one)

[sbueringer]

@Jont828 Thx. There's one last additional one (test/infrastructure/docker/exp/api/v1alpha4/dockermachinepool_types.go)

@fabriziopandini We have two MachinePool YAMLs in test/infrastructure/docker/config/crd/bases. Imho we can/should delete test/infrastructure/docker/config/crd/bases/infrastructure.cluster.x-k8s.io_dockermachinepools.yaml.

[CecileRobertMichon]

@sbueringer Jonathan and I found the issue with the dockermachinepool kubebuilder generation when looking at this, I believe he's going to open a separate PR to fix it (the groupName kubebuilder comment is wong in groupversion_info.go). For now excluding dockermachinepools from this change because generation isn't working until we fix the above issue.

[Jont828]

Yep, as Cecile mentioned, I'm going to create a separate PR after this to fix the bug with dockermachinepools and add the age to it.

[Jont828]

Do all the changes look good? If so, I'll squash and get ready to merge.

[CecileRobertMichon]

lgtm

[sbueringer]

lgtm

And thx for taking care of this :). I was going mad debugging weird bugs in the ClusterClass topology controller without the age column, it's very helpful!!

[Jont828]

Np, happy to help! I just squashed everything into one commit. Hopefully everything passes and we're good to go.

[CecileRobertMichon]

/lgtm

[vincepri]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment