🐛 fix reconciler kv in our reconciler loggers #5170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
sbueringer
force-pushed
the
pr-fix-reconciler-log-name-kv
branch
from
9923a3d to
92c05ad
Compare
|
After we upgrade to the next controller-runtime release (for kubernetes-sigs/controller-runtime#1648) The logs will look like this: I0827 18:07:09.474490 64958 controller.go:207] controller/dockercluster "msg"="Starting workers" "reconciler group"="infrastructure.cluster.x-k8s.io" "reconciler kind"="DockerCluster" "worker count"=1 |
Signed-off-by: Stefan Büringer [email protected]
sbueringer
force-pushed
the
pr-fix-reconciler-log-name-kv
branch
from
92c05ad to
2282884
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
This is the root cause of the panic in CAPD fixed here: #5167 (review)
With the current main version we have an uneven k/v count. This means as soon as we try to log something with a non-string as value klog will panic (as previously in CAPD)
I hope I got all, would be good if somebody could check again
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #