🐛 fix ClusterClass control plane infrastructure machine template rotation

[sbueringer]

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:
I tested a template rotation locally and it failed. It failed because the name of the new template was invalid. getClusterName returns an empty string, so this results in a name like -controlplane-s13ds1.

Note: ClusterName in ObjectMeta is not used by CAPI. Go doc:

	// The name of the cluster which the object belongs to.
	// This is used to distinguish resources with same name and namespace in different clusters.
	// This field is not set anywhere right now and apiserver is going to ignore it if set in create or update request.
	// +optional
	ClusterName string `json:"clusterName,omitempty" protobuf:"bytes,15,opt,name=clusterName"`

I adjusted the code accordingly.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[fabriziopandini]

Good catch!
/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [fabriziopandini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[killianmuldoon]

/lgtm - thanks for catching this! Good context about the ClusterName field too.

[fabriziopandini]

/test pull-cluster-api-test-main-mink8s