🌱 Move Predicates allow logs to V6 #5148
Conversation
fabriziopandini
requested review from
vincepri,
sbueringer and
CecileRobertMichon
k8s-ci-robot
added
cncf-cla: yes
| return true | ||
| } | ||
| } | ||
| log.V(4).Info("All of the provided predicates returned false, blocking further processing") | ||
| log.V(6).Info("All of the provided predicates returned false, blocking further processing") |
There was a problem hiding this comment.
I might have misunderstood the PR description, but shouldn't those stay at 4?
My tl;dr was every blocking predicate (i.e. logs in combination with return false) should stay at 4.
Or only a subset of those?
There was a problem hiding this comment.
@sbueringer those are log entry from All and Any, which provides combinations of predicates (the point number 3 in the PR discription); they should be moved at level 6 because they are "echoing" blocking predicates logs from other predicates (they are redundant).
There was a problem hiding this comment.
Okay perfect, thx for the explanation!
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold |
k8s-ci-robot
added
do-not-merge/hold
|
hold canceled |
What this PR does / why we need it:
Currently in Cluster API, when log is >=4, predicates start reporting several logs entries reporting:
This is really chatty given that we are using predicates in many places, and it makes reading Cluster API log hard/difficult to use log levels >=4.
This PR implement a solution for this problem by moving logs of category 2 and 3 to v6, while instead "object reconciliation being blocked by predicates" will continue to be logger at v4.