🌱 kcp: convert infrastructure machine ref API contract #5143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
sbueringer
commented
Aug 24, 2021
sbueringer
changed the title
|
flake |
|
/lgtm note to self: open a issue to refactor ConvertReferenceAPIContract to don't required restConfig |
k8s-ci-robot
added
the
lgtm
sbueringer
force-pushed
the
pr-kcp-convert-machine-ref
branch
from
08097fd to
b2ec1d5
Compare
k8s-ci-robot
removed
the
lgtm
|
/test pull-cluster-api-e2e-full-main |
sbueringer
force-pushed
the
pr-kcp-convert-machine-ref
branch
from
b2ec1d5 to
29e4260
Compare
|
/test pull-cluster-api-e2e-full-main |
sbueringer
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
sbueringer
force-pushed
the
pr-kcp-convert-machine-ref
branch
from
29e4260 to
49e9ec0
Compare
|
Now also adjusted RBAC accordingly |
sbueringer
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
minor nit, but otherwise lgtm |
sbueringer
force-pushed
the
pr-kcp-convert-machine-ref
branch
from
49e9ec0 to
2b14b18
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/hold let's wait for #5160 |
k8s-ci-robot
added
the
do-not-merge/hold
Signed-off-by: Stefan Büringer [email protected]
sbueringer
force-pushed
the
pr-kcp-convert-machine-ref
branch
from
2b14b18 to
408f30b
Compare
k8s-ci-robot
removed
the
lgtm
|
/test pull-cluster-api-e2e-full-main |
|
/retest |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
This PR adjusts KCP so that the infrastructure machine template reference is automatically converted if necessary.
xref: #5131 (comment)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #