🌱 Create internal/check package for ClusterClass #5135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
sbueringer
reviewed
Aug 23, 2021
k8s-ci-robot
added
the
lgtm
|
/lgtm cancel Pending @sbueringer comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
fabriziopandini
force-pushed
the
cluster-class-create-check-package
branch
from
6e0ad71 to
79cea85
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR creates and internal/check package for ClusterClass by moving some code from the main controllers/topology folder.
Anything else you would like to add:
@vincepri I investigated a little bit introducing a singleton so we can have
check.Compatibility().., but at the end I rolled back those changes because it seemed to me to over-engineer the code given that at this stage we have only one kind of checks.We can always iterate in the future if the need arises.