🐛 clusterctl: fix target namespace in v1beta1 CRDs and WebhookConfigurations

[sbueringer]

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:
Currently, clusterctl only overwrites the target namespace of v1 CRDs and WebhookConfigurations. This PR adjusts clusterctl to also handle the v1beta1 versions.

Note: this has to be supported because v1alpha4 providers are not required to use the v1 versions of those resources.

After this fix clusterctl also returns better errors when used together with v1alpha3 provider versions, i.e.

Error: current version of clusterctl is only compatible with v1alpha4 providers, detected v1alpha3 for provider infrastructure-aws

instead of:

Fetching providers
Error: failed to get provider components for the "aws" provider: failed to set the TargetNamespace on the components: converting (v1beta1.MutatingWebhookConfiguration) to (v1.MutatingWebhookConfiguration): unknown conversion

xref: https://kubernetes.slack.com/archives/C8TSNPY4T/p1629101098162100

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[sbueringer]

/cc @fabriziopandini @asalkeld

[k8s-ci-robot]

@sbueringer: GitHub didn't allow me to request PR reviews from the following users: asalkeld.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @fabriziopandini @asalkeld

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vincepri]

/lgtm
/assign @fabriziopandini

[sbueringer]

flakes
/retest

[asalkeld]

lgtm
@sbueringer I don't see any code related to After his fix clusterctl also returns better errors when used together with v1alpha3 provider versions, i.e. (or am I missing something?)

[sbueringer]

lgtm
@sbueringer I don't see any code related to After his fix clusterctl also returns better errors when used together with v1alpha3 provider versions, i.e. (or am I missing something?)

Kind of :). If fix target namespace doesn't fail anymore, the code execution continues and in case of usage with a v1alpha3 provider eventually returns e.g. the Error: current version of clusterctl is only compatible with v1alpha4 providers, detected v1alpha3 for provider infrastructure-aws error.

I mostly added this comment in the description because there was a lot of confusion in Slack because a few folks tried to use clusterctl v0.4.x with v1alpha3 providers and got the fix target namespace error instead of the compatibility error.

[fabriziopandini]

@sbueringer thanks for picking up this work!
/lgtm

[vincepri]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment