-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add dynamic completion support for context in kubeconfig and namespace #5094
✨ Add dynamic completion support for context in kubeconfig and namespace #5094
Conversation
Hi @superbrothers. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
How can I modify this PR to pass |
@superbrothers I think there's no reasonably easy way to do it. But apidiff is not required for merge and I think we don't have strong compatibility guarantees for clusterctl which would prevent your changes (but let's wait for Fabrizio's opinion on that). |
@enxebre @JoelSpeed ping |
Have had a read through, no additional feedback from me, though I'm not an expert in this area. Code looks clean, I think I understand what it's doing and how it should work, so LGTM. |
/assign @CecileRobertMichon |
4a1c15b
to
2b13645
Compare
2b13645
to
d1c7c0e
Compare
@superbrothers: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR adds dynamic completion support for context in kubeconfig and namespace.
--kubeconfig-context
flagclusterctl move --to-kubeconfig-context
flag--namespace
flag--target-namespace
flag--from-config-map-namespace
flagWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):ref/ #4089