Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Move the ClusterTopologyReconciler to a separated package #5071

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
This PR moves the ClusterTopologyReconciler to a separated package, separating it from the other controller that are stable.

NOTE: this PR is only re-shuffling things, no additional changes applied

Which issue(s) this PR fixes:
Fixes #5038

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 10, 2021
@fabriziopandini
Copy link
Member Author

@killianmuldoon PTAL

@sbueringer
Copy link
Member

/lgtm
(diffed all files to be sure, and it looks good)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2021
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should rethink the clusterclass.go file as it doesn't make it clear what that functionality the file actually has. Could the getClass function be joined with currentstate.go? It seems that the functions fit well together.

Otherwise maybe it could be called classreader.go or something that titles what it does. Other than this I have no other nits.

@sbueringer
Copy link
Member

sbueringer commented Aug 10, 2021

One option could be to name it currentclusterclass analog to currentstate which signals a bit that we retrieve the current clusterclass/state in those files. But I have no strong opinion on that.

@fabriziopandini fabriziopandini force-pushed the move-clustertopologyreconciler-to-separated-package branch from 14a48fb to 00556a3 Compare August 10, 2021 16:50
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2021
@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
pull-cluster-api-apidiff-main 00556a3 link /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit ee0f31d into kubernetes-sigs:master Aug 10, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Aug 10, 2021
@fabriziopandini fabriziopandini deleted the move-clustertopologyreconciler-to-separated-package branch August 10, 2021 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move clustertopology controller code to controllers/topology
5 participants