-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Move the ClusterTopologyReconciler to a separated package #5071
🌱 Move the ClusterTopologyReconciler to a separated package #5071
Conversation
@killianmuldoon PTAL |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should rethink the clusterclass.go file as it doesn't make it clear what that functionality the file actually has. Could the getClass function be joined with currentstate.go? It seems that the functions fit well together.
Otherwise maybe it could be called classreader.go or something that titles what it does. Other than this I have no other nits.
One option could be to name it |
14a48fb
to
00556a3
Compare
@fabriziopandini: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR moves the ClusterTopologyReconciler to a separated package, separating it from the other controller that are stable.
NOTE: this PR is only re-shuffling things, no additional changes applied
Which issue(s) this PR fixes:
Fixes #5038