Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix clusterctl upgrade cert-manager version detection previously detecting v0.11 when using EndpointSlices #5051

Merged
merged 1 commit into from
Aug 6, 2021
Merged

🐛 Fix clusterctl upgrade cert-manager version detection previously detecting v0.11 when using EndpointSlices #5051

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/clusterctl/client/cluster/cert_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,8 +304,8 @@ func (cm *certManagerClient) shouldUpgrade(objs []unstructured.Unstructured) (st
for i := range objs {
obj := objs[i]

// Endpoints are generated by Kubernetes without the version annotation, so we are skipping them
if obj.GetKind() == "Endpoints" {
// Endpoints and EndpointSlices are generated by Kubernetes without the version annotation, so we are skipping them
if obj.GetKind() == "Endpoints" || obj.GetKind() == "EndpointSlice" {
continue
}

Expand Down