🐛 fix panic in clusterctl backup #5050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/assign @fabriziopandini |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
vincepri
reviewed
Aug 4, 2021
| @@ -366,7 +366,7 @@ func (o *objectMover) backup(graph *objectGraph, directory string) error { | |||
| moveSequence := getMoveSequence(graph) | |||
|
|
|||
| // Save all objects group by group | |||
| log.Info("Saving files to %s", directory) | |||
| log.Info(fmt.Sprintf("Saving files to %s", directory)) | |||
There was a problem hiding this comment.
Does this logger not have Infof?
There was a problem hiding this comment.
For future reference, let's make sure that PR titles have more explicit information, like Fix panic in logger not using string interpolation ....
There was a problem hiding this comment.
Yup will do. The logger has no Infof func (it's the go-logr/logr.Logger interface)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Without this change clusterctl backup panics because of an uneven amount of key-value arguments. The unit test didn't catch this as it's using the
NullLoggerWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #