Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 upgrade clusterctl used for e2e test upgrade tests to v0.3.22 #4995

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:
This PR updates the clusterctl version we use for our clusterctl upgrade e2e test. I assume we want to use more or less the latest version.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 22, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 22, 2021
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Soon or later we have to find a way to automate this...
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2021
@k8s-ci-robot k8s-ci-robot merged commit daf871f into kubernetes-sigs:master Jul 22, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Jul 22, 2021
@sbueringer sbueringer deleted the pr-upgrade-clusterctl-upgrade-test branch July 22, 2021 13:03
@sbueringer
Copy link
Member Author

Thanks! Soon or later we have to find a way to automate this...
/lgtm
/approve

Conceptually we could also just specify something like "latest v0.3.x" and then our code searches on Github what the latest release/binary is? (Afaik similar to what clusterctl does right now with the YAMLs)

@sbueringer
Copy link
Member Author

Thanks! Soon or later we have to find a way to automate this...
/lgtm
/approve

Conceptually we could also just specify something like "latest v0.3.x" and then our code searches on Github what the latest release/binary is? (Afaik similar to what clusterctl does right now with the YAMLs)

/cc @fabriziopandini

@fabriziopandini
Copy link
Member

Yes, that's the idea...
Alternative is to use some version files like in Kubernetes CI and update them during release.

@sbueringer
Copy link
Member Author

Yes, that's the idea...
Alternative is to use some version files like in Kubernetes CI and update them during release.

Yeah that could be interesting for all kinds of CAPI consumers like it is in the case of Kubernetes (although they have a few more consumers :))

@fabriziopandini
Copy link
Member

Let's open an issue...

@sbueringer
Copy link
Member Author

@fabriziopandini I put it on my list, probably tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants