Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ upgrade cert-manager to v1.4.0 #4990

Merged
merged 1 commit into from
Jul 21, 2021
Merged

✨ upgrade cert-manager to v1.4.0 #4990

merged 1 commit into from
Jul 21, 2021

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Jul 21, 2021 •
edited
Loading

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:
cert-manager v1.1.0 does not work on Kubernetes v1.22.

Note:

xref release notes:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4983

@sbueringer
upgrade cert-manager to v1.4.0
b7aa613 
Signed-off-by: Stefan Büringer [email protected]
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 21, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 21, 2021 •
edited
Loading

@sbueringer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
pull-cluster-api-apidiff-main b7aa613 link /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbueringer
Copy link
Member Author

/test pull-cluster-api-test-main
(only the (unfortunately) usual flakes)

@sbueringer sbueringer changed the title [WIP] ✨ upgrade cert-manager to v1.4.0 ✨ upgrade cert-manager to v1.4.0 Jul 21, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2021
@sbueringer
Copy link
Member Author

/cc @CecileRobertMichon @vincepri @fabriziopandini @randomvariable

@fabriziopandini I think I got everything relevant. I grepped for cert-manager- and v1.1.0.

@sbueringer
Copy link
Member Author

sbueringer commented Jul 21, 2021 •
edited
Loading

Release notes look clean to me. A lot of changes but only very few marked as breaking and imho they don’t affect us

I also tested locally:

  • ✅ clusterctl init on v1.22-rc.0 locally and cert-manager came up.
  • ✅ run quickstart e2e test with kindest/node:v1.22.0-rc.0

Yey first successful management cluster on Kubernetes v1.22 (at least the first one I saw :))

@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2021
CecileRobertMichon
CecileRobertMichon reviewed Jul 21, 2021
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

vincepri
vincepri approved these changes Jul 21, 2021
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2021
@k8s-ci-robot k8s-ci-robot merged commit e3b758d into kubernetes-sigs:master Jul 21, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Jul 21, 2021
@sbueringer sbueringer deleted the pr-upgrade-certmanager branch July 22, 2021 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@vincepri vincepri vincepri approved these changes

@enxebre enxebre Awaiting requested review from enxebre

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@randomvariable randomvariable Awaiting requested review from randomvariable

Assignees

@fabriziopandini fabriziopandini

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.

Upgrade cert-manager for Kubernetes v1.22
5 participants
@sbueringer @k8s-ci-robot @fabriziopandini @vincepri @CecileRobertMichon