Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ v0.3.x: block clusterctl init and move on Kubernetes v1.22 #4984

Merged
merged 1 commit into from
Jul 29, 2021
Merged

✨ v0.3.x: block clusterctl init and move on Kubernetes v1.22 #4984

merged 1 commit into from
Jul 29, 2021

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Jul 21, 2021 •
edited
Loading

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:
See issue for details.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Partially implements #4966 (1., only clusterctl in this PR)

@k8s-ci-robot k8s-ci-robot added this to the v0.3 milestone Jul 21, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 21, 2021
@k8s-ci-robot k8s-ci-robot requested review from benmoss and vincepri July 21, 2021 06:51
@sbueringer
Copy link
Member Author

@fabriziopandini I opened this PR to start a discussion on how to implement this. I added some conversations above with open questions from my side. Also totally fine if this should be implemented completely different :)

@sbueringer sbueringer force-pushed the pr-block-clusterctl-on-v1.22 branch from c9fb3b1 to 5ce49ff Compare July 26, 2021 14:16
@sbueringer sbueringer changed the title [WIP] ✨ block clusterctl init and move on Kubernetes v1.22 ✨ block clusterctl init and move on Kubernetes v1.22 Jul 26, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 26, 2021
@sbueringer
Copy link
Member Author

@fabriziopandini PTAL :)

@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2021
@sbueringer sbueringer force-pushed the pr-block-clusterctl-on-v1.22 branch from 5ce49ff to ec8bc3e Compare July 28, 2021 16:41
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2021
@sbueringer
Copy link
Member Author

sbueringer commented Jul 28, 2021 •
edited
Loading

@fabriziopandini fyi: I renamed the 1.22 constant to managementClusterVersionCeiling to keep it consistent with the one which implements the block in KCP

@k8s-ci-robot
Copy link
Contributor

@sbueringer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
pull-cluster-api-apidiff-release-0-3 ec8bc3e link /test pull-cluster-api-apidiff-release-0-3

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbueringer sbueringer changed the title ✨ block clusterctl init and move on Kubernetes v1.22 ✨ v0.3.x: block clusterctl init and move on Kubernetes v1.22 Jul 28, 2021
vincepri
vincepri approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2021
@sbueringer
Copy link
Member Author

@fabriziopandini I think I just need another lgtm from you for merge (only changed the var name since the last one)

@vincepri
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit b3cb57e into kubernetes-sigs:release-0.3 Jul 29, 2021
@sbueringer sbueringer deleted the pr-block-clusterctl-on-v1.22 branch July 29, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@vincepri vincepri vincepri approved these changes

@benmoss benmoss Awaiting requested review from benmoss

Assignees

@vincepri vincepri

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3
Development

Successfully merging this pull request may close these issues.
4 participants
@sbueringer @fabriziopandini @k8s-ci-robot @vincepri