🌱 Randomly generated namespace in controllers pkg tests

[GrigoriyMikhalkin]

Partly solves #4629. Only controllers pkg is updated.

Use of randomly generated namespaces was started in #4698. This PR continues it's work in the same manner. env.CreateNamespace is used everywhere internal envtest package is used for testing. And everywhere else(for example tests that use fake.Client from controller-runtime) it replaces "default" and "test" namespace names with constant metav1.NamespaceDefault.

[k8s-ci-robot]

Hi @GrigoriyMikhalkin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vincepri]

/ok-to-test

[fabriziopandini]

@GrigoriyMikhalkin thanks for this PR, tests cleanups are always welcome!
Two general comments before going thought a more detailed review:

• Please make sure to cleanup the randomly generated namespaces
• Instead of moving tests from hardcoded default to default constant, what about moving to a random generated namespace so we can ensure better isolation?

[fabriziopandini]

/lgtm
please squash commits before merge

[schrej]

please squash commits before merge

You can also add a label to do that btw.: /label tide/merge-method-squash
Not sure if that works here as well, but it does on k/k

[vincepri]

@schrej It does, although we still prefer if folks squash to avoid long commit message descriptions that aren't super useful later on

[sbueringer]

I thought PR's merged via Prow squash are not picked up by our release note tool?

[vincepri]

/assign @fabriziopandini @sbueringer

[fabriziopandini]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [fabriziopandini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment