✨ Add ability to set DockerClusterSpec load balancer #4951
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
stmcginnis
changed the title
|
Looks like I'll need some pointers on the object conversion handling. |
stmcginnis
force-pushed
the
capd-lbconfig
branch
from
7f51dda to
c765c9a
Compare
k8s-ci-robot
added
the
needs-rebase
stmcginnis
force-pushed
the
capd-lbconfig
branch
from
c765c9a to
e720e57
Compare
k8s-ci-robot
removed
the
needs-rebase
|
/retest |
stmcginnis
force-pushed
the
capd-lbconfig
branch
from
e720e57 to
f44a080
Compare
|
@fabriziopandini it would be great to get your feedback on how I tied in using the image setting for the loadbalancer.Create() call. Just let me know if there are alternatives that would be preferable to how that was done. |
stmcginnis
changed the title
|
@vincepri I didn't follow your suggestion because I wasn't quite sure how that would fit here. But now that I have a working skeleton in place, maybe you could point out where you think it could be improved? |
|
@stmcginnis PR looks great to me @sbueringer PTAL |
k8s-ci-robot
added
the
lgtm
|
@stmcginnis just a bunch of nits |
We need the ability to set the repository and tag of the load balancer to use. This adds a field to the DockerClusterSpec in the v1alpha4 API to enable this. Signed-off-by: Sean McGinnis <[email protected]>
stmcginnis
force-pushed
the
capd-lbconfig
branch
from
f44a080 to
7264f91
Compare
k8s-ci-robot
removed
the
lgtm
|
Thx!! |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
We need the ability to set the repository and tag of the load balancer
to use. This adds a field to the DockerClusterSpec in the v1alpha4 API
to enable this.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #4950