🐛 fix unhandled errors

[sbueringer]

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:
I think it makes sense to either handle errors or ignore them explicitly

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Implements a part of #4622

[randomvariable]

/lgtm
/retest

[JoelSpeed]

This is fine as is but added a couple of notes for potential improvements, very minor/stylistic and definitely non-blocking

[sbueringer]

Thx for the reviews, ptal @enxebre @JoelSpeed

(I hope/assume the apidiff is not a problem)

[JoelSpeed]

/lgtm

Looking at the diff, seems we've changed the signature of some machinedeployment controlelr utils, that appears to be handled within this PR and I doubt that code is used outside of the project, so I think that should be ok

[sbueringer]

/test pull-cluster-api-test-main
I assume those were flakes, tests worked locally.

[sbueringer]

@vincepri I also added ComputeSpewHash to avoid breaking API compatiblity of ComputeHash. PTAL

[vincepri]

/lgtm
/hold cancel

[sbueringer]

/cc @fabriziopandini

[vincepri]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sbueringer]

/retest

[vincepri]

This is new, @sbueringer can you check if the flake is reproducible locally?

/hold

[sbueringer]

@vincepri I don't think it's related:

• the previous failure had other failed tests (the same commit has 2 successfull runs of this test): https://prow.k8s.io/pr-history/?org=kubernetes-sigs&repo=cluster-api&pr=4895
• it already failed on the main branch last Friday:
  • https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api#capi-test-main&include-filter-by-regex=TestGetWorkloadCluster&exclude-non-failed-tests=
  • https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/periodic-cluster-api-test-main/1413261062446256128
• Ran it locally a few times without error
• As far as I can see I didn't change any code related to the kubeadm control plane controller

Hopefully the retest will also work :)

/retest

[sbueringer]

@vincepri I think we can merge this PR.

[CecileRobertMichon]

/hold cancel
/lgtm