Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 kubetest: Remove usage of Viper, converting config files to kubetest arguments #4761

Merged

Conversation

randomvariable
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4729

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 8, 2021
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 8, 2021
@randomvariable
Copy link
Member Author

Need to test it.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 8, 2021
@randomvariable randomvariable changed the title kubetest: Remove usage of Viper, converting config files to kubetest arguments 🌱 kubetest: Remove usage of Viper, converting config files to kubetest arguments Jun 8, 2021
to kubetest arguments

Signed-off-by: Naadir Jeewa <[email protected]>
@randomvariable randomvariable force-pushed the remove-kubetest-viper branch from 81a29ad to 8445e16 Compare June 8, 2021 16:29
@randomvariable randomvariable marked this pull request as ready for review June 8, 2021 16:29
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 8, 2021
@randomvariable
Copy link
Member Author

randomvariable commented Jun 8, 2021

tested locally with CAPA

@randomvariable
Copy link
Member Author

/retest

Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2021
@randomvariable
Copy link
Member Author

/retest

@vincepri
Copy link
Member

vincepri commented Jun 8, 2021

/override pull-cluster-api-test-main

Tests are passing except for the known flake.

@k8s-ci-robot
Copy link
Contributor

@vincepri: Overrode contexts on behalf of vincepri: pull-cluster-api-test-main

In response to this:

/override pull-cluster-api-test-main

Tests are passing except for the known flake.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove use of Viper in kubetest framework
3 participants