🌱 Align v1beta3 types to latest changes in Kubernetes #4751
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
/retest |
1 similar comment
|
/retest |
| // The list of phases can be obtained with the "kubeadm join --help" command. | ||
| // The flag "--skip-phases" takes precedence over this field. | ||
| // +optional | ||
| SkipPhases []string `json:"skipPhases,omitempty"` |
There was a problem hiding this comment.
I thought we were going to hold on adding SkipPhases for now?
There was a problem hiding this comment.
We are adding it only to the v1beta3 types, which are a mirror of the kubeadm ones used only when serialising the Cluster API's KubeadmConfig object.
However we are not adding skip phases to the v1alpha4 KubeadmConfig object, so this field will be hidden to the CAPI users
k8s-ci-robot
added
the
lgtm
|
/assign @CecileRobertMichon |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
This PR alignes v1beta3 types to latest changes in Kubernetes
For sake consistency, some minor changes (+optional) are applied to KubeadmConfig in Cluster API v1alpha4 API.
@vincepri @CecileRobertMichon