Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 CAPD: Fix for Linux security update to not set conntrack sysctls #4728

Conversation

randomvariable
Copy link
Member

Cherry pick of #4717 on release-0.3.

#4717: Fix for Linux security update

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added this to the v0.3 milestone Jun 7, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 7, 2021
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 7, 2021
@randomvariable randomvariable changed the title Automated cherry pick of #4717: Fix for Linux security update 🐛 CAPD: Fix for Linux security update to not set conntrack sysctls Jun 7, 2021
Prevents kube-proxy when running in non-root network namespace from attempting
to modify global sysctls which are now read-only.

Signed-off-by: Naadir Jeewa <[email protected]>
@randomvariable randomvariable force-pushed the automated-cherry-pick-of-#4717-release-0.3 branch from 21fd805 to 1c95760 Compare June 7, 2021 12:09
@randomvariable
Copy link
Member Author

Are more linters enforced on release-0.3 than the main branch?

@randomvariable
Copy link
Member Author

/retest

Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2021
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit e8edb2f into kubernetes-sigs:release-0.3 Jun 7, 2021
@randomvariable randomvariable deleted the automated-cherry-pick-of-#4717-release-0.3 branch June 7, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants