Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Introduce const for ClusterctlCoreLabel inventory value #4726

Merged
merged 1 commit into from
Jun 7, 2021
Merged

🌱 Introduce const for ClusterctlCoreLabel inventory value #4726

merged 1 commit into from
Jun 7, 2021

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
Introduce a const for the "inventory" value to be used for the ClusterctlCoreLabel

@k8s-ci-robot k8s-ci-robot requested review from enxebre and JoelSpeed June 4, 2021 19:19
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 4, 2021
@enxebre
Copy link
Member

enxebre commented Jun 7, 2021 •
edited
Loading

Although it's not mentioned in the commit/title the code seems to be introducing also another const ClusterctlCoreLabelCertManagerValue?

@fabriziopandini fabriziopandini force-pushed the introduce-ClusterctlCoreLabelInventoryValue-const branch from 00673cd to f2da39d Compare June 7, 2021 13:15
@fabriziopandini
Copy link
Member Author

Although it's not mentioned in the commit/title the code seems to be introducing also another const ClusterctlCoreLabelCertManagerValue?

Removed ClusterctlCoreLabelCertManagerValue

vincepri
vincepri approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2021
@fabriziopandini
Copy link
Member Author

/retest

2 similar comments
@fabriziopandini
Copy link
Member Author

/retest

@vincepri
Copy link
Member

vincepri commented Jun 7, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit 369c3ca into kubernetes-sigs:master Jun 7, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Jun 7, 2021
@fabriziopandini fabriziopandini deleted the introduce-ClusterctlCoreLabelInventoryValue-const branch June 7, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@enxebre enxebre Awaiting requested review from enxebre

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.
4 participants
@fabriziopandini @enxebre @k8s-ci-robot @vincepri