⚠️ ClusterResourceSet should not use a predicate on secret Type with metadata objects

[sedefsavas]

What this PR does / why we need it:
When only metadata is cached for secrets, CRS predicates do not have the type info and hence does not trigger reconcile when a Secret with CRS secret type (addons.cluster.x-k8s.io/resource-set) is created.

This PR caches full Secret object in CRS.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4218

[k8s-ci-robot]

@sedefsavas: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-cluster-api-apidiff-main	e965ade	link	/test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[sedefsavas]

I think it'd be good to backport this.

[vincepri]

/lgtm
/assign @CecileRobertMichon
/retitle 🐛 ClusterResourceSet should not use a predicate on secret Type with metadata objects

[vincepri]

/retitle ⚠️ ClusterResourceSet should not use a predicate on secret Type with metadata objects

Marking it as a breaking change given that it removes an exported function.

@sedefsavas If we do backport, we need to deprecate the predicate rather than removing it

[vincepri]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment